Use OS Agnostic Temporary Directory #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-nightly[bot]](https://avatars.githubusercontent.com/in/324098?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #367, which pointed out that the current implementation of the temporary directory in
sweepai/app/ui.pyis not compatible with Windows.The Python
osmodule provides a functionos.path.join(tempfile.gettempdir(), repo_full_name)that can be used to create a temporary directory that is OS agnostic. This function has been used to replace the current usage of"/tmp/" + repo_full_namein theget_filesfunction.This change ensures that Sweep can be used across different operating systems without encountering issues related to the creation of temporary directories.
Fixes #367.
To checkout this PR branch, run the following command in your terminal: